Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayland: Dedupe wayland GL/VK configure code again #17320

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

wayland: Dedupe wayland GL/VK configure code again #17320

wants to merge 1 commit into from
+150 −214

Conversation

ColinKinloch
Copy link
Contributor

@ColinKinloch ColinKinloch commented Dec 31, 2024 •
edited
Loading

Configurations of xdg_toplevels are pending until acked on xdg_surface configure.

The vulkan backend doesn't need to take additional actions on configure.

Incorporates changes from #17317

I was intending on polishing it a bit more but if it's better than the current state it may be worth merging.

Related Issues

#16198 (comment)

Related Pull Requests

#17309

Reviewers

@Sunderland93

@ColinKinloch ColinKinloch mentioned this pull request Dec 31, 2024
Open
@Sunderland93
Copy link
Contributor

Thanks! On KDE Plasma 6 the issue in #16198 (comment) is gone! On Plasma 5.25 it still there, so maybe it is a bug in Plasma/Kwin itself. The only issue that I found is resizing window in Vulkan backend: black borders around window content while resizing.

_20250101_145650.mp4

@ColinKinloch
Copy link
Contributor Author

The black boarder seems to be an issue with retroarchs vulkan code as it also happens on x11.

@ColinKinloch
wayland: Dedupe wayland GL/VK configure code again
e22d788 
Configurations of xdg_toplevels are pending until acked on xdg_surface
configure.

The vulkan backend doesn't need  to take additional actions on configure.
@ColinKinloch
Copy link
Contributor Author

I pushed some small changes.
They're unlikely to fix the issues on kwin 5.25.

@LibretroAdmin
Copy link
Contributor

LibretroAdmin commented Jan 1, 2025 •
edited
Loading

When you guys think this is ready for merging, just let me know. No rush though in case stuff still needs to be sorted out.

@ColinKinloch
Copy link
Contributor Author

I think its in a much better state than master. It's probably worth merging now.

@Sunderland93
Copy link
Contributor

Sunderland93 commented Jan 2, 2025 •
edited
Loading

They're unlikely to fix the issues on kwin 5.25.

Issue with maximizing window is totally fixed, but issue with initial window size (window too small) is still in place. In Plasma 6.2 no issues at all.

@ColinKinloch
Copy link
Contributor Author

Which distro is 5.25?
I'd be interested to know if it's still happening with Debian stable (5.27.5)

@Sunderland93
Copy link
Contributor

Debian stable (5.27.5)

This

@ColinKinloch
Copy link
Contributor Author

Is it dual monitor (splash screen)?
I've just now replicated it with weston with a single output.

@Sunderland93
Copy link
Contributor

Is it dual monitor (splash screen)?

No, single monitor

@ColinKinloch ColinKinloch marked this pull request as draft January 3, 2025 00:34
@ColinKinloch
Copy link
Contributor Author

I've got a branch that fixes Weston as well (and hopefully the preview version of kwin-wayland)
It makes some of the changes in this branch unessesary so I made it draft.

@ColinKinloch
Copy link
Contributor Author

ColinKinloch commented Jan 4, 2025 •
edited
Loading

I think I'll remove the splash screen altogether.
On mutter surfaces map on the output the cursor is currently on, unless the surface is fullscreen in which case it is mapped to the leftmost monitor.
I think the splash screen was there to force the window to become fullscreen on the monitor the cursor was on.
I'm not sure this is intended behaviour or a bug, either way I don't think RetroArch should work around it.

I'll create an issue on the mutter repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColinKinloch @Sunderland93 @LibretroAdmin